Messages in this thread | | | Date | Mon, 5 Mar 2012 15:13:49 +0100 | From | Borislav Petkov <> | Subject | Re: [PATCH 4/4] EDAC: Convert AMD EDAC pieces to use RAS printk buffer |
| |
On Mon, Mar 05, 2012 at 10:35:47AM -0300, Mauro Carvalho Chehab wrote: > No. This is an example that you're not reading my emails:
Unfortunately, I read your emails.
> no other driver needs that. So, it is something that it is specific to > the MCA amd64 drivers.
Let me spell it for ya: no, it's specific to x86, and not to amd64_edac.
> The other two MCA drivers are sb_edac and i7core_edac. I wrote both drivers, and they > don't need any helper function to store strings on a temporary buffer. > > Also, the edac core is not x86-specific. So, referencing to a var there (ras_agent) > that it is defined inside arch/x86 would break Kernel compilation on all other > architectures.
That's more like it.
It can be moved to an arch-agnostic place or be defined __attribute__((weak)) in edac_core.c. Unless someone has a better idea, of course.
[..]
> As already pointed out, you're not reading my emails. The above were at the version 1 of > my patches, with I sent at least a month ago. Since version 2, what is proposed is to use: > > TRACE_EVENT(mc_error_mce, > > for MCA-based memory error events. There's also a variant for non-MCA drivers (mc_error). > > [1] http://git.kernel.org/?p=linux/kernel/git/mchehab/linux-edac.git;a=commitdiff;h=4eb2a29419c1fefd76c8dbcd308b84a4b52faf4d
I see at least 4 misdesigned tracepoints there:
trace_mc_out_of_range_mce trace_mc_out_of_range trace_mc_error_mce trace_mc_error ...
so NACK to those.
> I also wrote on my emails that, instead of having a tracepoint > specific for memory errors, it is possible to re-define the fields > I've proposed to cover CPU location/socket label, and that this is > better than folding everything into a hard-to-parse single string > message.
No, this is repurposing the fields of memory errors, which is ugly. So, no.
-- Regards/Gruss, Boris.
Advanced Micro Devices GmbH Einsteinring 24, 85609 Dornach GM: Alberto Bozzo Reg: Dornach, Landkreis Muenchen HRB Nr. 43632 WEEE Registernr: 129 19551
| |