lkml.org 
[lkml]   [2012]   [Mar]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH] sysfs: Optionally count subdirectories to support buggy applications
    On 02/02/2012 12:18 AM, Linus Torvalds wrote:
    > On Wed, Feb 1, 2012 at 3:15 PM, Linus Torvalds
    > <torvalds@linux-foundation.org> wrote:
    >>
    >> No extra "keep track of inode counts by hand" crap, and no idiotic
    >> config options that just make it easy to (conditionally) get things
    >> wrong. Just do it right, and do it *unconditionally* right.
    >
    > And btw, "nlink shows number of subdirectories" for a directory entry
    > really *is* right. It's how Unix filesystems work, like it or not.
    >
    > It's mainly lazy/bad filesystems that set nlink to 1. So the whole
    > "nlink==1" case is meant for crap like FAT etc, not for a filesystem
    > that we control and that could easily just do it right.
    >
    > Which is why I detest that config option. It's as if you were asking the user
    >
    > "Do you want to make the sysfs filesystem act like crap filesystems?"
    >
    > and kernel config time. What kind of inane question is that?

    <thread resumed...>

    What's going on here? I still have to revert "sysfs: Kill nlink
    counting." with today's -next to have working sensors.

    thanks,
    --
    js
    suse labs


    \
     
     \ /
      Last update: 2012-03-05 14:33    [W:5.366 / U:0.236 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site