Messages in this thread | | | Date | Mon, 5 Mar 2012 12:07:43 +0000 | From | Mark Brown <> | Subject | Re: [PULL-REQUEST] EXTCON Patches (Re: [PATCH v6 0/5] Introduce External Connector Class (extcon)) |
| |
On Mon, Mar 05, 2012 at 04:59:42PM +0900, MyungJoo Ham wrote: > On Wed, Feb 29, 2012 at 9:35 PM, Mark Brown
> > For things like headphone detection the actual switch they're providing > > has issues too even just within the switch API - it's called "h2w" with > > magic values.
> Reading an H2W switch device driver > (http://git.ziggy471.com/frankenstine.git/plain/arch/arm/mach-msm/htc_headset_mgr.c), > I don't see why it won't be compatible after replacing the name from
That's not the only such driver, that's one example of a machine specific accessory detection driver. There's others out there such as the sec_jack driver which you converted into the ADC driver in your patches (if you look at how that gets deployed the overwhelming majority of users are headsets).
The issue is the combination of the naming (h2w isn't very meaningful and only works with a single jack) and the magic numbers used for reporting state, plus the registration collisions. Existing code can be ported over fairly easily but it's got issues as an ABI which we'd want to fix. [unhandled content-type:application/pgp-signature] | |