lkml.org 
[lkml]   [2012]   [Mar]   [31]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH] debugobjects: Use GFP_ATOMIC to allocate when initializing
    On Sat, Mar 31, 2012 at 05:22:52PM -0400, Sasha Levin wrote:
    > During the init stage, we have only 1 cpu and run with IRQs disabled,

    debug_objects_mem_init() is called after local_irq_enable() in
    start_kernel()

    > we can't allocate with GFP_KERNEL.
    >
    > This also fixes the related warning on boot.

    Not sure how you get that.

    Thanks,
    Yong


    >
    > Signed-off-by: Sasha Levin <levinsasha928@gmail.com>
    > ---
    > lib/debugobjects.c | 2 +-
    > 1 files changed, 1 insertions(+), 1 deletions(-)
    >
    > diff --git a/lib/debugobjects.c b/lib/debugobjects.c
    > index 0ab9ae8..ece5e06 100644
    > --- a/lib/debugobjects.c
    > +++ b/lib/debugobjects.c
    > @@ -1020,7 +1020,7 @@ static int __init debug_objects_replace_static_objects(void)
    > int i, cnt = 0;
    >
    > for (i = 0; i < ODEBUG_POOL_SIZE; i++) {
    > - obj = kmem_cache_zalloc(obj_cache, GFP_KERNEL);
    > + obj = kmem_cache_zalloc(obj_cache, GFP_ATOMIC);
    > if (!obj)
    > goto free;
    > hlist_add_head(&obj->node, &objects);
    > --
    > 1.7.8.5
    >
    > --
    > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    > the body of a message to majordomo@vger.kernel.org
    > More majordomo info at http://vger.kernel.org/majordomo-info.html
    > Please read the FAQ at http://www.tux.org/lkml/

    --
    Only stand for myself


    \
     
     \ /
      Last update: 2012-04-01 04:33    [W:4.699 / U:0.004 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site