lkml.org 
[lkml]   [2012]   [Mar]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH 1/8] Documentation: remove 'mach' from dontdiff file
On Fri, Mar 30, 2012 at 1:36 PM, Randy Dunlap <rdunlap@xenotime.net> wrote:
> From: H Hartley Sweeten <hartleys@visionengravers.com>
>
> Documentation: remove mach from dontdiff file

Grr.

Most of these patches have the same stupid problem: why the *hell* do
you repeat the single-line top-level description in both the Subject
line and the body of the email? It only results in stupid duplicate
lines in the commit logs.

This is a disease. I don't know who the heck started doing it, but
it's WRONG. It's stupid. What broken piece-of-shit tool is it that
does this braindamage?

Fix it. Stop sending these broken commit messages to people.

I'm grumpy, yes, because this is a common problem. I see it all over
the place, and it makes our commit logs look f*cking retarded.

If you absolutely need to repeat the subject line in the body of the
email, do it together with the author line, and mark it as such, ie do
this:

From: H Hartley Sweeten <hartleys@visionengravers.com>
Subject: Documentation: remove mach from dontdiff file

so that git sees that it's a repeat of the subject line. Don't just
put it in the body as another stupid repeat.

Linus


\
 
 \ /
  Last update: 2012-03-31 00:43    [W:0.042 / U:13.456 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site