lkml.org 
[lkml]   [2012]   [Mar]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[ 079/175] md/bitmap: ensure to load bitmap when creating via sysfs.
    3.3-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: NeilBrown <neilb@suse.de>

    commit 4474ca42e2577563a919fd3ed782e2ec55bf11a2 upstream.

    When commit 69e51b449d383e (md/bitmap: separate out loading a bitmap...)
    created bitmap_load, it missed calling it after bitmap_create when a
    bitmap is created through the sysfs interface.
    So if a bitmap is added this way, we don't allocate memory properly
    and can crash.

    This is suitable for any -stable release since 2.6.35.
    Signed-off-by: NeilBrown <neilb@suse.de>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    drivers/md/bitmap.c | 2 ++
    1 file changed, 2 insertions(+)

    --- a/drivers/md/bitmap.c
    +++ b/drivers/md/bitmap.c
    @@ -1904,6 +1904,8 @@ location_store(struct mddev *mddev, cons
    if (mddev->pers) {
    mddev->pers->quiesce(mddev, 1);
    rv = bitmap_create(mddev);
    + if (!rv)
    + rv = bitmap_load(mddev);
    if (rv) {
    bitmap_destroy(mddev);
    mddev->bitmap_info.offset = 0;



    \
     
     \ /
      Last update: 2012-03-30 23:23    [W:0.019 / U:0.368 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site