lkml.org 
[lkml]   [2012]   [Mar]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[ 026/175] USB: gadget: Make g_hid device class conform to spec.
    3.3-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Orjan Friberg <of@flatfrog.com>

    commit 33d2832ab0149a26418d360af3c444969a63fb28 upstream.

    HID devices should specify this in their interface descriptors, not in the
    device descriptor. This fixes a "missing hardware id" bug under Windows 7 with
    a VIA VL800 (3.0) controller.

    Signed-off-by: Orjan Friberg <of@flatfrog.com>
    Cc: Felipe Balbi <balbi@ti.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    drivers/usb/gadget/hid.c | 6 +++---
    1 file changed, 3 insertions(+), 3 deletions(-)

    --- a/drivers/usb/gadget/hid.c
    +++ b/drivers/usb/gadget/hid.c
    @@ -60,9 +60,9 @@ static struct usb_device_descriptor devi
    /* .bDeviceClass = USB_CLASS_COMM, */
    /* .bDeviceSubClass = 0, */
    /* .bDeviceProtocol = 0, */
    - .bDeviceClass = 0xEF,
    - .bDeviceSubClass = 2,
    - .bDeviceProtocol = 1,
    + .bDeviceClass = USB_CLASS_PER_INTERFACE,
    + .bDeviceSubClass = 0,
    + .bDeviceProtocol = 0,
    /* .bMaxPacketSize0 = f(hardware) */

    /* Vendor and product id can be overridden by module parameters. */



    \
     
     \ /
      Last update: 2012-03-30 23:21    [W:0.048 / U:0.048 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site