lkml.org 
[lkml]   [2012]   [Mar]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[ 070/149] md: dont set md arrays to readonly on shutdown.
    3.2-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: NeilBrown <neilb@suse.de>

    commit c744a65c1e2d59acc54333ce80a5b0702a98010b upstream.

    It seems that with recent kernel, writeback can still be happening
    while shutdown is happening, and consequently data can be written
    after the md reboot notifier switches all arrays to read-only.
    This causes a BUG.

    So don't switch them to read-only - just mark them clean and
    set 'safemode' to '2' which mean that immediately after any
    write the array will be switch back to 'clean'.

    This could result in the shutdown happening when array is marked
    dirty, thus forcing a resync on reboot. However if you reboot
    without performing a "sync" first, you get to keep both halves.

    This is suitable for any stable kernel (though there might be some
    conflicts with obvious fixes in earlier kernels).

    Signed-off-by: NeilBrown <neilb@suse.de>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    drivers/md/md.c | 37 +++++++++++++++----------------------
    1 file changed, 15 insertions(+), 22 deletions(-)

    --- a/drivers/md/md.c
    +++ b/drivers/md/md.c
    @@ -8097,30 +8097,23 @@ static int md_notify_reboot(struct notif
    struct mddev *mddev;
    int need_delay = 0;

    - if ((code == SYS_DOWN) || (code == SYS_HALT) || (code == SYS_POWER_OFF)) {
    -
    - printk(KERN_INFO "md: stopping all md devices.\n");
    -
    - for_each_mddev(mddev, tmp) {
    - if (mddev_trylock(mddev)) {
    - /* Force a switch to readonly even array
    - * appears to still be in use. Hence
    - * the '100'.
    - */
    - md_set_readonly(mddev, 100);
    - mddev_unlock(mddev);
    - }
    - need_delay = 1;
    + for_each_mddev(mddev, tmp) {
    + if (mddev_trylock(mddev)) {
    + __md_stop_writes(mddev);
    + mddev->safemode = 2;
    + mddev_unlock(mddev);
    }
    - /*
    - * certain more exotic SCSI devices are known to be
    - * volatile wrt too early system reboots. While the
    - * right place to handle this issue is the given
    - * driver, we do want to have a safe RAID driver ...
    - */
    - if (need_delay)
    - mdelay(1000*1);
    + need_delay = 1;
    }
    + /*
    + * certain more exotic SCSI devices are known to be
    + * volatile wrt too early system reboots. While the
    + * right place to handle this issue is the given
    + * driver, we do want to have a safe RAID driver ...
    + */
    + if (need_delay)
    + mdelay(1000*1);
    +
    return NOTIFY_DONE;
    }




    \
     
     \ /
      Last update: 2012-03-30 23:15    [W:0.021 / U:29.728 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site