[lkml]   [2012]   [Mar]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
Patch in this message
Subject[ 014/149] staging: r8712u: Fix regression introduced by commit a5ee652
3.2-stable review patch.  If anyone has any objections, please let me know.


From: Larry Finger <>

commit 9f4bc8cf3fe750ed093856a5f5d41c11cc12ad22 upstream.

In commit a5ee652 "staging: r8712u: Interface-state not fully tracked",
the private boolean "bup" was set false when the interface was brought down,
as that seemed appropriate. This change has not caused any problems when
using NetworkManager or manual control of the device; however, when wicd
control is used, there is a locking problem in wpa_supplicant, as shown in

This fix reverts the only code change in commit a5ee652. My
analysis is that "bup" is badly named. In its present form, it
seems to indicate the up/down state of the device, but its usage
is more consistent with an initialized/uninitialized state. That
problem will be addressed in a later patch.

Note: Commit 8c213fa, which introdued asynchronous firmware loading
for this driver, exposed this bug to a greater extent. That bug
is addressed in the next patch in this series.

This bug is also responsible for the bug in and this bug is
also part of the problems discussed at

Tested-by: Alberto Lago Ballesteros <>
Tested-by: Adrian <>
Signed-off-by: Larry Finger <>
Signed-off-by: Greg Kroah-Hartman <>

drivers/staging/rtl8712/os_intfs.c | 2 --
1 file changed, 2 deletions(-)

--- a/drivers/staging/rtl8712/os_intfs.c
+++ b/drivers/staging/rtl8712/os_intfs.c
@@ -476,8 +476,6 @@ static int netdev_close(struct net_devic
- /* The interface is no longer Up: */
- padapter->bup = false;
/* never exit with a firmware callback pending */

 \ /
  Last update: 2012-03-30 23:11    [W:0.321 / U:1.160 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site