Messages in this thread | | | Date | Fri, 30 Mar 2012 16:04:47 -0400 | From | Chris Mason <> | Subject | Re: [GIT PULL] Btrfs fixes and features |
| |
On Fri, Mar 30, 2012 at 12:54:03PM -0700, Linus Torvalds wrote: > On Fri, Mar 30, 2012 at 12:50 PM, Linus Torvalds > <torvalds@linux-foundation.org> wrote: > > > > This causes a new warning for me: > > > > fs/btrfs/extent_io.c: In function ‘repair_eb_io_failure’: > > fs/btrfs/extent_io.c:1940:6: warning: ‘ret’ may be used > > uninitialized in this function > > > > Hmm? > > Ok, so presumably num_pages (which is "num_extent_pages(eb->start, > eb->len)") cannot be zero, so I guess the code is ok. But gcc can't > know that, and it's an annoying warning.
Whoops, my reply was too slow, sorry. If you're curious my gcc that doesn't warn in 4.6.3.
> > So please fix, but it's not urgent. In the meantime I've pulled and pushed out.
Ok, I'll send just the incremental in a later pull.
-chris -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |