lkml.org 
[lkml]   [2012]   [Mar]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [GIT PULL] Disintegrate and kill asm/system.h
On Thu, Mar 29, 2012 at 03:14:29PM +1100, Benjamin Herrenschmidt wrote:
> > We are currently getting:
> > kernel/irq/irqdomain.c: In function 'irq_debugfs_init':
> > kernel/irq/irqdomain.c:698:63: error: 'powerpc_debugfs_root' undeclared (first use in this function)
> > kernel/irq/irqdomain.c:698:63: note: each undeclared identifier is reported only once for each function it appears in
> >
> > ae3a197 Disintegrate asm/system.h for PowerPC
> > is conflicting with
> > cc79ca6 irq_domain: Move irq_domain code from powerpc to kernel/irq
> > from Grant's tree.
> >
> > Adding the following patch fixes it for pseries_defconfig, although I'm
> > not sure it's the right fix.
>
> That will do as a quick fix (Linus, can you take it now ?), however..
>
> > Grant: why does powerpc_debugfs_root appear in generic code? This seems
> > very bogus.
>
> Yes, Grant, you should move that to a different (generic) debugfs file,
> the mapping information is valuable debug data for all architectures
> that use the remapper, not just powerpc and it's not an ABI (no tool I
> know of rely on the location of that debugfs file) so feel free to move
> it around.
>
There is a arch_debugfs_dir defined by linux/debugfs.h, but at the moment
it's only provided by x86 and sh.


\
 
 \ /
  Last update: 2012-03-30 09:51    [W:0.104 / U:0.072 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site