Messages in this thread | | | Date | Fri, 30 Mar 2012 10:09:14 -0700 | From | David Daney <> | Subject | Re: [PATCH 9/9] perf tools: Remove auto-generated bison/flex files |
| |
On 03/30/2012 09:43 AM, Namhyung Kim wrote: > Hi, > > Arnaldo Carvalho de Melo<acme@infradead.org> wrote: >> From: Ingo Molnar<mingo@kernel.org> >> >> These should not be in the Git history - they are auto-generated. >> >> Extend the Makefile rules of the parser files to include the generation >> run. >> >> Signed-off-by: Ingo Molnar<mingo@elte.hu> [...] >> >> +FLEX = $(CROSS_COMPILE)flex >> +BISON= $(CROSS_COMPILE)bison > > Just out of curiousity, is this $(CROSS_COMPILE) prefix really needed > for flex/bison? >
I think not. Actually, I think it is actively incorrect.
I have done quite a bit of cross building of things requiring either bison or flex, and have never encountered $(CROSS_COMPILE)bison, so I would think that it is unlikely that many people have one. On the other hand the native tools work fine.
David Daney
| |