lkml.org 
[lkml]   [2012]   [Mar]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 02/16 v2] Input: atmel_mxt_ts - only allow root to update firmware
    Date
    Restrict permissions on the update_fw sysfs entry to read only for root
    only.

    Also, update object permission to use a macro S_IRUGO macro instead of
    hard coded 0444.

    Signed-off-by: Daniel Kurtz <djkurtz@chromium.org>
    Reviewed-by: Joonyoung Shim <jy0922.shim@samsung.com>
    Acked-by: Nick Dyer <nick.dyer@itdev.co.uk>
    ---
    drivers/input/touchscreen/atmel_mxt_ts.c | 4 ++--
    1 files changed, 2 insertions(+), 2 deletions(-)

    diff --git a/drivers/input/touchscreen/atmel_mxt_ts.c b/drivers/input/touchscreen/atmel_mxt_ts.c
    index 0a6e368..15ae6fd 100644
    --- a/drivers/input/touchscreen/atmel_mxt_ts.c
    +++ b/drivers/input/touchscreen/atmel_mxt_ts.c
    @@ -1049,8 +1049,8 @@ static ssize_t mxt_update_fw_store(struct device *dev,
    return count;
    }

    -static DEVICE_ATTR(object, 0444, mxt_object_show, NULL);
    -static DEVICE_ATTR(update_fw, 0664, NULL, mxt_update_fw_store);
    +static DEVICE_ATTR(object, S_IRUGO, mxt_object_show, NULL);
    +static DEVICE_ATTR(update_fw, S_IWUSR, NULL, mxt_update_fw_store);

    static struct attribute *mxt_attrs[] = {
    &dev_attr_object.attr,
    --
    1.7.7.3


    \
     
     \ /
      Last update: 2012-03-29 18:53    [W:0.034 / U:60.224 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site