lkml.org 
[lkml]   [2012]   [Mar]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v3 4/7] libata: detech Device Attention support
From
Date
On Wed, 2012-03-28 at 15:22 +0400, Sergei Shtylyov wrote:
> Hello.
>
> On 28-03-2012 10:21, Lin Ming wrote:
>
> > Add a new flag ATA_DFLAG_DA to indicate that device supports "Device
> > Attention".
>
> > Acked-by: Aaron Lu<aaron.lu@amd.com>
> > Signed-off-by: Lin Ming<ming.m.lin@intel.com>
> [...]
>
> > diff --git a/include/linux/ata.h b/include/linux/ata.h
> > index 32df2b6..6ee41cc 100644
> > --- a/include/linux/ata.h
> > +++ b/include/linux/ata.h
> > @@ -578,6 +578,7 @@ static inline int ata_is_data(u8 prot)
> > ((u64) (id)[(n) + 0]) )
> >
> > #define ata_id_cdb_intr(id) (((id)[ATA_ID_CONFIG]& 0x60) == 0x20)
> > +#define atapi_id_has_da(id) ((id)[77]& (1<< 4))
>
> We prefix these macros with 'ata_' despite them being applied to IDENTIFY
> DEVICE data or IDENTIFY PAKCET DEVICE data. ata_id_cdb_intr(), for example,
> applies only to IDENTIFY PAKCET DEVICE data.

OK, will change it.

>
> MBR, Sergei




\
 
 \ /
  Last update: 2012-03-29 07:09    [W:0.069 / U:7.916 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site