lkml.org 
[lkml]   [2012]   [Mar]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH] virtio_blk: add helper function to support mass of disks naming
    On 03/29/2012 07:36 AM, Ren Mingxin wrote:
    > On 03/28/2012 06:58 PM, Michael S. Tsirkin wrote:
    >> On Wed, Mar 28, 2012 at 02:54:43PM +0800, Ren Mingxin wrote:
    >>> Hi,
    >>>
    >>> The current virtblk's naming algorithm just supports 26^3
    >>> disks. If there are mass of virtblks(exceeding 26^3), there
    >>> will be disks with the same name.
    >>>
    >>> According to "sd_format_disk_name()", I add function
    >>> "virtblk_name_format()" for virtblk to support mass of
    >>> disks.
    >>>
    >>> Signed-off-by: Ren Mingxin<renmx@cn.fujitsu.com>
    >> Nod. This is basically what 3e1a7ff8a0a7b948f2684930166954f9e8e776fe
    >> did. Except, maybe we should move this function into block core
    >> instead of duplicating it? Where would be a good place to put it?
    >
    > Yes, this was also what I thought.
    >
    > How about placing the "sd_format_disk_name()"
    > as "disk_name_format()" into "block/genhd.c"
    > ("include/linux/genhd.h")?

    Yes, that sounds like the appropriate solution (and name, and where to
    put it).

    --
    Jens Axboe



    \
     
     \ /
      Last update: 2012-03-29 14:09    [W:0.021 / U:153.672 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site