Messages in this thread | | | Subject | Re: [RFC] Remove most all #define pr_fmt(fmt) lines | From | Joe Perches <> | Date | Wed, 28 Mar 2012 00:30:03 -0700 |
| |
On Wed, 2012-03-28 at 09:27 +0200, Clemens Ladisch wrote: > Joe Perches wrote: > > With this change, objects like drivers/regulator/core.o > > are prefixed with "core: ". This is somewhat senseless > > and may prompt Makefile changes to make the prefixes for > > some objects more sensible. > > > > For example, modifying the Makefile to bundle objects > > together with a specific name can change the prefixes. > > Here the prefix becomes "regulator: " > > > > +++ b/drivers/regulator/Makefile > > > > +regulator-y := core.o dummy.o fixed-helper.o > > +regulator-objs := $(regulator-y) > > > > -obj-$(CONFIG_REGULATOR) += core.o dummy.o fixed-helper.o > > +obj-$(CONFIG_REGULATOR) += regulator.o > > > > ------------------ > > > > Any objections or other suggestions/improvements? > > Instead of doing a Makefile change that has no _obvious_ connection with > printk, wouldn't it be better to just define pr_fmt with "regulator: "?
Maybe, maybe not.
Bundling objects in a Makefile like this is pretty common and can also produce better module names.
| |