lkml.org 
[lkml]   [2012]   [Mar]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    Date
    SubjectRe: [PATCH 2/6] trace: add support for 32 bit compat syscalls on x86_64
    On Mon, Mar 26, 2012 at 9:49 PM, H. Peter Anvin <hpa@zytor.com> wrote:
    > On 03/26/2012 11:39 AM, Vaibhav Nagarnaik wrote:
    >> +/*
    >> + * syscall metadata for 32 bit compatible system calls
    >> + *
    >> + * The metadata entries are in the same order as the system call table
    >> + * but this is just to make it easier to check them for completeness
    >> + * and correctness.
    >> + */
    >> +
    >> +COMPAT_SYSCALL_METADATA0(restart_syscall)
    >> +COMPAT_SYSCALL_METADATA1(exit, int, error_code)
    >   [...]
    >> +COMPAT_SYSCALL_METADATA5(recvmmsg, int, fd, struct mmsghdr __user *, mmsg, unsigned int, vlen, unsigned int, flags, struct timespec __user *, timeout)
    >
    >> +/*
    >> + * This is truly horrible.
    >
    > Yes, it is.  How on Earth do you expect the above to ever be maintained?

    You are right. I found that I can just reuse the SYSCALL_DEFINEx macro
    to define the compat syscall metadata. I am sending the new patch, can
    you take a look again?


    Thanks


    Vaibhav Nagarnaik
    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2012-03-28 23:13    [W:0.023 / U:31.344 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site