Messages in this thread | | | From | hayeswang <> | Subject | RE: [PATCH net-next 1/5] r8169: modify pll power function | Date | Wed, 28 Mar 2012 10:52:24 +0800 |
| |
Francois Romieu [mailto:romieu@fr.zoreil.com] > Sent: Wednesday, March 28, 2012 6:54 AM > To: Hayeswang > Cc: netdev@vger.kernel.org; linux-kernel@vger.kernel.org > Subject: Re: [PATCH net-next 1/5] r8169: modify pll power function > > Hayes Wang <hayeswang@realtek.com> : > > Adjust r810x_pll_power_down, r810x_pll_power_up, and > r8168_pll_power_up. > > Always power up device during rtl_open. > > For r810x, turn off more power when the WOL is disabled. > > Would the "Always power up" part qualify as a "fix something" change ? >
I don't see any issue about this yet. It seems to be reasonable to make suer the device would work when the open is called no matter the power is turned off before or not.
Best Regards, Hayes
| |