lkml.org 
[lkml]   [2012]   [Mar]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH 2/2] firmware_class: Move request_firmware_nowait() to workqueues
Date
On Wednesday, March 28, 2012, Tejun Heo wrote:
> On Tue, Mar 27, 2012 at 02:28:30PM -0700, Stephen Boyd wrote:
> > Oddly enough a work_struct was already part of the firmware_work
> > structure but nobody was using it. Instead of creating a new
> > kthread for each request_firmware_nowait() call just schedule the
> > work on the long system workqueue. This should avoid some overhead
> > in forking new threads when they're not strictly necessary.
> >
> > Signed-off-by: Stephen Boyd <sboyd@codeaurora.org>
> > ---
> >
> > Is it better to use alloc_workqueue() and not put these on the system
> > long workqueue?
>
> No, just use schedule_work() unless there are specific requirements
> which can't be fulfilled that way (e.g. it's on memory allocation
> path, may consume large amount of cpu cycles, ...)

It may wait quite long.

Rafael


\
 
 \ /
  Last update: 2012-03-28 00:45    [W:0.124 / U:0.776 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site