lkml.org 
[lkml]   [2012]   [Mar]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 2/2] firmware_class: Move request_firmware_nowait() to workqueues
    On Tue, Mar 27, 2012 at 02:28:30PM -0700, Stephen Boyd wrote:
    > Oddly enough a work_struct was already part of the firmware_work
    > structure but nobody was using it. Instead of creating a new
    > kthread for each request_firmware_nowait() call just schedule the
    > work on the long system workqueue. This should avoid some overhead
    > in forking new threads when they're not strictly necessary.
    >
    > Signed-off-by: Stephen Boyd <sboyd@codeaurora.org>
    > ---
    >
    > Is it better to use alloc_workqueue() and not put these on the system
    > long workqueue?

    No, just use schedule_work() unless there are specific requirements
    which can't be fulfilled that way (e.g. it's on memory allocation
    path, may consume large amount of cpu cycles, ...)

    Thanks.

    --
    tejun


    \
     
     \ /
      Last update: 2012-03-28 00:03    [W:0.034 / U:1.444 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site