| Date | Tue, 27 Mar 2012 15:01:08 -0700 | From | Tejun Heo <> | Subject | Re: [PATCH 2/2] firmware_class: Move request_firmware_nowait() to workqueues |
| |
On Tue, Mar 27, 2012 at 02:28:30PM -0700, Stephen Boyd wrote: > Oddly enough a work_struct was already part of the firmware_work > structure but nobody was using it. Instead of creating a new > kthread for each request_firmware_nowait() call just schedule the > work on the long system workqueue. This should avoid some overhead > in forking new threads when they're not strictly necessary. > > Signed-off-by: Stephen Boyd <sboyd@codeaurora.org> > --- > > Is it better to use alloc_workqueue() and not put these on the system > long workqueue?
No, just use schedule_work() unless there are specific requirements which can't be fulfilled that way (e.g. it's on memory allocation path, may consume large amount of cpu cycles, ...)
Thanks.
-- tejun
|