lkml.org 
[lkml]   [2012]   [Mar]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH 09/13 v4] drm/i915/intel_i2c: use double-buffered writes
Date
On Wed, 28 Mar 2012 02:36:18 +0800, Daniel Kurtz <djkurtz@chromium.org> wrote:
> @@ -276,6 +269,13 @@ gmbus_xfer_write(struct drm_i915_private *dev_priv, struct i2c_msg *msg,
>
> I915_WRITE(GMBUS3 + reg_offset, val);
> POSTING_READ(GMBUS2 + reg_offset);

You might as well squash this posting read as the write flush is
redundant given the following read of GMBUS2.

> +
> + if (wait_for(I915_READ(GMBUS2 + reg_offset) &
> + (GMBUS_SATOER | GMBUS_HW_RDY),
> + 50))
> + return -ETIMEDOUT;
> + if (I915_READ(GMBUS2 + reg_offset) & GMBUS_SATOER)
> + return -ENXIO;

--
Chris Wilson, Intel Open Source Technology Centre


\
 
 \ /
  Last update: 2012-03-27 20:47    [W:0.106 / U:1.144 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site