[lkml]   [2012]   [Mar]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
    Subject[RFC PATCHSET] perf ui: Small preparation on further UI work

    This is my initial work of UI generalization. As we now get GTK2 support on
    perf report, improve setup_browser() to handle it properly so that we can
    add various UI specific initialization codes to the function. At least, we
    need basic error/warning handlers ASAP to see what's going on when an error
    occurred, IMHO.

    I put new file setup.c under ui directory (not under util/ui) and it may or
    may not be compiled depending on the system configuration. I think it'd be
    better moving generic UI codes to the directory and TUI specific codes to
    ui/tui, and so on, so that the util directory doesn't contain any UI codes.
    But before proceeding, I'd like to listen to your opinions :).

    Any comments are welcome.

    Namhyung Kim (5):
    perf ui: Make setup_browser() generic
    perf ui: Drop arg[cv] arguments from perf_gtk_setup_browser()
    perf ui: Add gtk2 support into setup_browser()
    perf gtk: Rename functions for consistency
    perf ui: Change fallback policy of setup_browser()

    tools/perf/Makefile | 7 ++++-
    tools/perf/builtin-report.c | 5 +---
    tools/perf/ui/setup.c | 44 +++++++++++++++++++++++++++++
    tools/perf/util/cache.h | 24 +++++++++++-----
    tools/perf/util/gtk/browser.c | 27 +++++++++---------
    tools/perf/util/gtk/gtk.h | 4 +++
    tools/perf/util/ui/setup.c | 61 +++++++++++++++-------------------------
    7 files changed, 108 insertions(+), 64 deletions(-)
    create mode 100644 tools/perf/ui/setup.c


     \ /
      Last update: 2012-03-26 10:53    [W:0.021 / U:0.120 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site