lkml.org 
[lkml]   [2012]   [Mar]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v4] x86, olpc: add debugfs interface for EC commands
From
Date
andrew wrote:
> On Mon, 26 Mar 2012 19:07:07 +0100 (BST)
> Daniel Drake <dsd@laptop.org> wrote:
>
> > Add a debugfs interface for sending commands to the OLPC Embedded
> > Controller (EC) and reading the responses. The EC provides functionality
> > for machine identification, battery and AC control, wakeup control, etc.
> >
> > Having a debugfs interface available is useful for EC development and
> > debugging.
> >
> > Based on code by Paul Fox.
> >
> > Signed-off-by: Daniel Drake <dsd@laptop.org>
> > Originally-from: Paul Fox <pgf@laptop.org>
> > Cc: Ingo Molnar <mingo@elte.hu>
> > Cc: Thomas Gleixner <tglx@linutronix.de>
> > Cc: "H. Peter Anvin" <hpa@zytor.com>
> > Cc: Andres Salomon <dilinger@queued.net>
> >
> > ...
> >
> > v4: really fix sign-off tags
>
> s/fix/break/? "Originally-from" is not a recognised tag. If this code
> is based upon an earlier version from Paul then Signed-off-by: is
> correct.
>
> What's going on here? What are you trying to communicate?


i think the way daniel had it before was likely correct.

i wrote the original code, but it looked pretty different back then.
daniel has brought it to its current state. i _then_ added my
Signed-off-by.

so the code is both "Based on code by Paul Fox", and my Signed-off-by
should come after daniel's (assuming chronological order).

paul
=---------------------
paul fox, pgf@laptop.org


\
 
 \ /
  Last update: 2012-03-27 00:23    [W:0.190 / U:0.284 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site