| From | Andrea Arcangeli <> | Subject | [PATCH 22/39] autonuma: select_task_rq_fair cleanup new_cpu < 0 fix | Date | Mon, 26 Mar 2012 19:46:09 +0200 |
| |
Cleanup comment in the case find_idlest_cpu returned -1 and check for < 0 instead of == -1 as it should allow gcc to generate more optimal code.
Signed-off-by: Andrea Arcangeli <aarcange@redhat.com> --- kernel/sched/fair.c | 5 ++--- 1 files changed, 2 insertions(+), 3 deletions(-)
diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c index a8498e0..0c60f46 100644 --- a/kernel/sched/fair.c +++ b/kernel/sched/fair.c @@ -2792,10 +2792,9 @@ select_task_rq_fair(struct task_struct *p, int sd_flag, int wake_flags) if (new_cpu == -1 || new_cpu == cpu) { /* Now try balancing at a lower domain level of cpu */ sd = sd->child; - if (new_cpu == -1) { - /* Only for certain that new cpu is valid */ + if (new_cpu < 0) + /* Return prev_cpu is find_idlest_cpu failed */ new_cpu = prev_cpu; - } continue; }
|