| Subject | Re: [PATCH 11/39] autonuma: CPU follow memory algorithm | From | Peter Zijlstra <> | Date | Mon, 26 Mar 2012 20:25:53 +0200 |
| |
On Mon, 2012-03-26 at 19:45 +0200, Andrea Arcangeli wrote: > @@ -3220,6 +3214,8 @@ need_resched: > > post_schedule(rq); > > + sched_autonuma_balance(); > + > sched_preempt_enable_no_resched(); > if (need_resched()) > goto need_resched;
I already told you, this isn't ever going to happen. You do _NOT_ put a for_each_online_cpu() loop in the middle of schedule().
You also do not call stop_one_cpu(migration_cpu_stop) in schedule to force migrate the task you just scheduled to away from this cpu. That's retarded.
Nacked-by: Peter Zijlstra <a.p.zijlstra@chello.nl>
|