lkml.org 
[lkml]   [2012]   [Mar]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH 11/39] autonuma: CPU follow memory algorithm
From
Date
On Mon, 2012-03-26 at 19:45 +0200, Andrea Arcangeli wrote:
> @@ -3220,6 +3214,8 @@ need_resched:
>
> post_schedule(rq);
>
> + sched_autonuma_balance();
> +
> sched_preempt_enable_no_resched();
> if (need_resched())
> goto need_resched;

I already told you, this isn't ever going to happen. You do _NOT_ put a
for_each_online_cpu() loop in the middle of schedule().

You also do not call stop_one_cpu(migration_cpu_stop) in schedule to
force migrate the task you just scheduled to away from this cpu. That's
retarded.

Nacked-by: Peter Zijlstra <a.p.zijlstra@chello.nl>


\
 
 \ /
  Last update: 2012-03-26 20:43    [W:0.203 / U:2.032 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site