lkml.org 
[lkml]   [2012]   [Mar]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
From
Date
SubjectRe: Remove over-broad module alias from zaurus.
On Mon, Mar 26, 2012 at 2:49 PM, Dave Jones <davej@redhat.com> wrote:
> On Mon, Mar 26, 2012 at 10:39:48AM +0200, Guan Xin wrote:
>  > > On Fri, 17 Jun 2011 20:02:10 -0400, Dave Jones wrote:
>  > > This module and a bunch of dependancies are getting loaded on several
>  > > of laptops I have (probably picking up the mobile broadband device),
>  > > that have nothing to do with zaurus. Matching by class without
>  > > any vendor/device pair isn't the right thing to do here, as it
>  > > will prevent any other driver from correctly binding to it.
>  > > (Or in the absense of a driver, will just waste time & memory by
>  > >  unnecessarily loading modules)
>  > >
>  > > Signed-off-by: Dave Jones <davej@redhat.com>
>  > > -  USB_INTERFACE_INFO(USB_CLASS_COMM, USB_CDC_SUBCLASS_MDLM,
>  > > -                  USB_CDC_PROTO_NONE),
>  > > -  .driver_info = (unsigned long) &bogus_mdlm_info,
>  > > -}, {
>  > >    /* Motorola MOTOMAGX phones */
>  > >    USB_DEVICE_AND_INTERFACE_INFO(0x22b8, 0x6425, USB_CLASS_COMM,
>  > >                    USB_CDC_SUBCLASS_MDLM, USB_CDC_PROTO_NONE),
>  >
>  > After removal of this, my Motorola Rokr E6 (22b8:6027) cannot be recognized.
>  > Can this be added back with more specific device info, just like the
>  > Motorola MOTOMAGX phones?
>
> Yes, just cut-n-paste one of the other entries, change the ID,
> make sure it works and send a diff.
>
>        Dave

This patch is tested to work with 2.6.39.4 and 3.2.13.

--- a/drivers/net/usb/zaurus.c 2012-03-26 14:59:36.702998639 +0200
+++ b/drivers/net/usb/zaurus.c 2012-03-26 15:02:16.860801959 +0200
@@ -332,6 +332,11 @@
.driver_info = ZAURUS_PXA_INFO,
},
{
+ /* Motorola Rokr E6 */
+ USB_DEVICE_AND_INTERFACE_INFO(0x22b8, 0x6027, USB_CLASS_COMM,
+ USB_CDC_SUBCLASS_MDLM, USB_CDC_PROTO_NONE),
+ .driver_info = (unsigned long) &bogus_mdlm_info,
+}, {
/* Motorola MOTOMAGX phones */
USB_DEVICE_AND_INTERFACE_INFO(0x22b8, 0x6425, USB_CLASS_COMM,
USB_CDC_SUBCLASS_MDLM, USB_CDC_PROTO_NONE),
Guan
[unhandled content-type:application/octet-stream]
\
 
 \ /
  Last update: 2012-03-26 15:17    [W:0.042 / U:0.280 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site