lkml.org 
[lkml]   [2012]   [Mar]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH] of/irq: add empty irq_of_parse_and_map() for non-dt builds
From
On 25 March 2012 06:12, Grant Likely <grant.likely@secretlab.ca> wrote:
> On Sat, 24 Mar 2012 08:12:39 -0500, Rob Herring <robherring2@gmail.com> wrote:
>> On 03/24/2012 04:27 AM, Thomas Abraham wrote:
>> > Add a empty irq_of_parse_and_map() that returns 0 for non-dt builds and
>> > avoid having #ifdef CONFIG_OF around all calls to irq_of_parse_and_map().
>> >
>> > Suggested-by: Grant Likely <grant.likely@secretlab.ca>
>> > Signed-off-by: Thomas Abraham <thomas.abraham@linaro.org>
>> > ---
>>
>> Acked-by: Rob Herring <rob.herring@calxeda.com>
>>
>> Go ahead and merge with the rest of your series.
>
> Actually, it's not quite fully baked; the forward declaration of
> irq_of_parse_and_map() needs to be moved under the #if
> defined(CONFIG_OF_IRQ) block (just move the #if statement up 7 lines).
> After doing that you can add my acked-by and merge it with the rest of
> your series.  There is no sense merging it through my tree when you
> are the only user depending on it.
>
> Acked-by: Grant Likely <grant.likely@secretlab.ca>

Thanks. I will do that change which you have suggested and take it
through the Samsung tree. But I was thinking that if it goes through
your tree, there would be less chances of a merge conflict in
include/linux/of_irq.h, a file that might see updates from other
sources.

Thanks,
Thomas.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2012-03-25 16:59    [W:0.073 / U:0.052 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site