lkml.org 
[lkml]   [2012]   [Mar]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    Subject[PATCH 0/6] firmware_class: Fix problems with usermodehelper test
    Date
    Hi all,

    The following series of patches fixes two problems with
    request_firmware() and request_firmware_nowait() resulting from commit
    a144c6a6c924aa1da04dd77fb84b89927354fdff

    PM: Print a warning if firmware is requested when tasks are frozen

    The first problem is that request_firmware_nowait() may fail if it happens
    to run in parallel with system suspend. It should't fail in such situations
    and that is addressed by the first three patches (that code has been discussed
    with Linus at al already).

    The second issue is that request_firmware() may be called in a thread which
    isn't related to system suspend and if suspend happens exactly at that time,
    request_firmware() will fail (and print a scary warning), although it shouldn't.
    This problem is addressed by the remaining three patches, which are new.

    [1/6] - Rework the usermodehelper check in _request_firmware().
    [2/6] - Split _request_firmware() into three functions.
    [3/6] - If firmware is to be loaded asynchronously, wait for usermodehelper_disabled
    to be unset instead of failing the operation.
    [4/6] - Unify the hibernation/suspend code's usage of usermodehelper_disable().
    [5/6] - Move usermodehelper_disable() into freeze_processes().
    [6/6] - Make freezable threads calling request_firware() avoid the race with the
    freezer.

    Thanks,
    Rafael



    \
     
     \ /
      Last update: 2012-03-26 00:05    [W:4.033 / U:0.096 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site