lkml.org 
[lkml]   [2012]   [Mar]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
From
Subject[PATCH] gpio/sodaville: Mark broken due to core irqdomain migration
Date
The sodaville driver doesn't build anymore due to the transition to
common irq_domain in the core code. It needs to be reworked, but
the rework isn't trivial. Since this is a new driver anyway for
v3.4, mark it as broken now and a fixup patch can re-enable it when
the rework change has been tested.

Signed-off-by: Grant Likely <grant.likely@secretlab.ca>
Cc: Hans J. Koch <hjk@linutronix.de>
Cc: Torben Hohn <torbenh@linutronix.de>
Cc: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
---

Hans,

I'm sorry that I need to do this, but the irqdomain rework broke this
driver. The fixup turns out to be non-trivial so I'm not confident to
just merge it. I'll send you the draft patch that I have to fix it up
in a separate email. It will be up to you to test and repost it.
However, the fix doesn't need to wait for v3.5; I'm okay to take a
fixup patch after the merge window closes.

Cheers,
g.

drivers/gpio/Kconfig | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/gpio/Kconfig b/drivers/gpio/Kconfig
index dbb1909..dfea1d8 100644
--- a/drivers/gpio/Kconfig
+++ b/drivers/gpio/Kconfig
@@ -419,7 +419,7 @@ config GPIO_ML_IOH

config GPIO_SODAVILLE
bool "Intel Sodaville GPIO support"
- depends on X86 && PCI && OF
+ depends on X86 && PCI && OF && BROKEN
select GPIO_GENERIC
select GENERIC_IRQ_CHIP
help
--
1.7.9.1


\
 
 \ /
  Last update: 2012-03-25 01:33    [W:0.028 / U:0.144 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site