lkml.org 
[lkml]   [2012]   [Mar]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH] modpost: Fix modpost's license checking V3
    On 03/23/12 19:04, Frank Rowand wrote:
    > On 07/13/11 23:51, Alessio Igor Bogani wrote:
    >> The commit f02e8a6 sorts symbols placing each of them in its own elf section.
    >> The sorting and merging into the canonical sections are done by the linker.
    >> Unfortunately modpost to generate Module.symvers file parses vmlinux
    >
    > Yet another unfortunately: modpost parses vmlinux.o instead of vmlinux (vmlinux
    > does not yet exist at this point of the build). vmlinux.o also does not have
    > the many sections sorted and merged into the canonical sections. As a result,
    > the Module.symvers created my modpost incorrectly reports the license of all

    ^^^ s/my/by/

    > exports as "(unknown)".
    >
    > Can you fix this also please?
    >
    >
    >> (already linked) and all modules object files (which aren't linked yet).
    >> These aren't sanitized by the linker yet. That breaks modpost that can't
    >> detect license properly for modules. This patch makes modpost aware of
    >> the new exported symbols structure.
    >>
    >> Thanks to Arnaud Lacombe <lacombar@gmail.com> and Anders Kaseorg
    >> <andersk@ksplice.com> for providing useful suggestions about code.
    >>
    >> This work was supported by a hardware donation from the CE Linux Forum.
    >>
    >> Reported-by: Jan Beulich <jbeulich@novell.com>
    >> Signed-off-by: Alessio Igor Bogani <abogani@kernel.org>
    >> ---
    >> scripts/mod/modpost.c | 29 ++++++++++++++++++++++++++++-
    >> 1 files changed, 28 insertions(+), 1 deletions(-)
    >
    > < snip >
    >
    > -Frank Rowand
    > .
    >




    \
     
     \ /
      Last update: 2012-03-24 03:29    [from the cache]
    ©2003-2014 Jasper Spaans. hosted at Digital Ocean