[lkml]   [2012]   [Mar]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: linux-next: build failure after merge of the scsi tree
On 03/23/2012 06:26 AM, Alexey Dobriyan wrote:
> On Fri, Mar 23, 2012 at 7:50 AM, Benjamin Herrenschmidt
> <> wrote:
>> On Fri, 2012-03-23 at 13:00 +1100, Stephen Rothwell wrote:
>>> Hi James,
>>> After merging the scsi tree, today's linux-next build (powerpc
>>> ppc64_defconfig) failed like this:
>>> drivers/ata/sata_svw.c: In function 'k2_sata_proc_open':
>>> drivers/ata/sata_svw.c:327:2: error: implicit declaration of function 'PDE' [-Werror=implicit-function-declaration]
>>> drivers/ata/sata_svw.c:327:56: error: invalid type argument of '->' (have 'int')
>>> drivers/ata/sata_svw.c:328:1: warning: control reaches end of non-void function [-Wreturn-type]
>>> Caused by commit 343ac4b031a7 ("[SCSI] sata_svw: convert to scsi proc_ops").
>>> I have used the scsi tree from next-20120322 for today.
>> Additionally, I am the author and maintainer of that driver and I don't
>> remember ever being CCed on that patch ... or did I miss it ?
> Your email was not mentioned in changelogs for 6 years nor the driver
> has specific MAINTAINERS entry.

At the top of drivers/ata/sata_svw.c, we find:

* Maintained by: Benjamin Herrenschmidt <> and
* Jeff Garzik <>
* Please ALWAYS copy
* on emails.

and in MAINTAINERS we also find

M: Jeff Garzik <>
T: git
S: Supported
F: drivers/ata/

None of these addresses, nor LKML, were copied. Please do so in the future.


 \ /
  Last update: 2012-03-23 16:33    [from the cache]
©2003-2014 Jasper Spaans. hosted at Digital Ocean