lkml.org 
[lkml]   [2012]   [Mar]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: linux-next: build failure after merge of the scsi tree
    On 03/23/2012 06:26 AM, Alexey Dobriyan wrote:
    > On Fri, Mar 23, 2012 at 7:50 AM, Benjamin Herrenschmidt
    > <benh@kernel.crashing.org> wrote:
    >> On Fri, 2012-03-23 at 13:00 +1100, Stephen Rothwell wrote:
    >>> Hi James,
    >>>
    >>> After merging the scsi tree, today's linux-next build (powerpc
    >>> ppc64_defconfig) failed like this:
    >>>
    >>> drivers/ata/sata_svw.c: In function 'k2_sata_proc_open':
    >>> drivers/ata/sata_svw.c:327:2: error: implicit declaration of function 'PDE' [-Werror=implicit-function-declaration]
    >>> drivers/ata/sata_svw.c:327:56: error: invalid type argument of '->' (have 'int')
    >>> drivers/ata/sata_svw.c:328:1: warning: control reaches end of non-void function [-Wreturn-type]
    >>>
    >>> Caused by commit 343ac4b031a7 ("[SCSI] sata_svw: convert to scsi proc_ops").
    >>>
    >>> I have used the scsi tree from next-20120322 for today.
    >>
    >> Additionally, I am the author and maintainer of that driver and I don't
    >> remember ever being CCed on that patch ... or did I miss it ?
    >
    > Your email was not mentioned in changelogs for 6 years nor the driver
    > has specific MAINTAINERS entry.


    At the top of drivers/ata/sata_svw.c, we find:

    * Maintained by: Benjamin Herrenschmidt <benh@kernel.crashing.org> and
    * Jeff Garzik <jgarzik@pobox.com>
    * Please ALWAYS copy linux-ide@vger.kernel.org
    * on emails.

    and in MAINTAINERS we also find

    SERIAL ATA (SATA) SUBSYSTEM
    M: Jeff Garzik <jgarzik@pobox.com>
    L: linux-ide@vger.kernel.org
    T: git
    git://git.kernel.org/pub/scm/linux/kernel/git/jgarzik/libata-dev.git
    S: Supported
    F: drivers/ata/

    None of these addresses, nor LKML, were copied. Please do so in the future.

    Jeff





    \
     
     \ /
      Last update: 2012-03-23 16:33    [W:0.035 / U:1.344 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site