Messages in this thread | | | Date | Thu, 22 Mar 2012 23:34:26 -0400 (EDT) | Subject | Re: [PATCH] gianfar: Fix possible overrun and simplify interrupt name field creation | From | David Miller <> |
| |
From: David Miller <davem@davemloft.net> Date: Wed, 21 Mar 2012 22:34:57 -0400 (EDT)
> From: Joe Perches <joe@perches.com> > Date: Sat, 17 Mar 2012 12:05:38 -0700 > >> Space allocated for int_name_<foo> is unsufficient for >> maximal device name, expand it. >> >> Code to create int_name_<foo> is obscure, simplify it >> by using sprintf. >> >> Found by looking for unnecessary \ line continuations. >> Uncompiled, untested. >> >> Signed-off-by: Joe Perches <joe@perches.com> > > Can a gianfar expert please review and test this patch?
If you gianfar guys don't show a sign of life in the next 24 hours I'm just going to apply Joe's patch as-is. I refuse to just let it rot in patchwork like this.
And then you don't get to complain if his change breaks your driver because I asked multiple times for testing and/or review.
| |