lkml.org 
[lkml]   [2012]   [Mar]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH] gianfar: Fix possible overrun and simplify interrupt name field creation
From
From: David Miller <davem@davemloft.net>
Date: Wed, 21 Mar 2012 22:34:57 -0400 (EDT)

> From: Joe Perches <joe@perches.com>
> Date: Sat, 17 Mar 2012 12:05:38 -0700
>
>> Space allocated for int_name_<foo> is unsufficient for
>> maximal device name, expand it.
>>
>> Code to create int_name_<foo> is obscure, simplify it
>> by using sprintf.
>>
>> Found by looking for unnecessary \ line continuations.
>> Uncompiled, untested.
>>
>> Signed-off-by: Joe Perches <joe@perches.com>
>
> Can a gianfar expert please review and test this patch?

If you gianfar guys don't show a sign of life in the next 24 hours I'm
just going to apply Joe's patch as-is. I refuse to just let it rot in
patchwork like this.

And then you don't get to complain if his change breaks your driver
because I asked multiple times for testing and/or review.


\
 
 \ /
  Last update: 2012-03-23 04:37    [from the cache]
©2003-2011 Jasper Spaans