Messages in this thread Patch in this message | | | Date | Thu, 22 Mar 2012 14:51:22 -0700 | From | Andrew Morton <> | Subject | Re: [PATCH] backlight: Use id->driver_data to differentiate lp855x chips |
| |
On Wed, 21 Mar 2012 18:11:27 +0800 Axel Lin <axel.lin@gmail.com> wrote:
> Current code has corresponding driver_data settings for different chip types. > Use the driver_data to differentiate lp855x chips. > > Also make lp855x_is_valid_rom_area() return bool instead of int. > > -static int lp855x_is_valid_rom_area(struct lp855x *lp, u8 addr) > +static bool lp855x_is_valid_rom_area(struct lp855x *lp, u8 addr) > { > > ... > > - return (addr >= start && addr <= end) ? 1 : 0; > + return (addr >= start && addr <= end) ? true : false; > }
This:
--- a/drivers/video/backlight/lp855x_bl.c~backlight-use-id-driver_data-to-differentiate-lp855x-chips-fix +++ a/drivers/video/backlight/lp855x_bl.c @@ -82,7 +82,7 @@ static bool lp855x_is_valid_rom_area(str return false; } - return (addr >= start && addr <= end) ? true : false; + return (addr >= start && addr <= end); } static int lp855x_init_registers(struct lp855x *lp) _
| |