Messages in this thread | | | Subject | Re: [PATCH 1/1] checkpatch.pl: thou shalt not use () or (...) in function declarations | From | Joe Perches <> | Date | Thu, 22 Mar 2012 12:00:28 -0700 |
| |
On Thu, 2012-03-22 at 13:17 -0400, Valdis.Kletnieks@vt.edu wrote: > Those can be 'int foo(void)' can't they? The other historical usage is for > 'int foo()' to denote an old K&R-style varargs list, which is like disco - a > bad idea from long agon that's never coming back. ;) > > Of course, if we add this to checkpatch, we'll have a flood of fixup patches.
Not really, more like a mist than a flood. There just aren't many in-kernel uses. There are 10 in drivers/, 15 in arch/, none in include/
$ grep -rP --include=*.[ch] "^\w+\s+\w+\s*\(\s*(?:\.\.\.){0,1}\s*\)" *
A single trivial patch should work for all of them.
> Maybe we just need to say "3.5 will be the int foo() housecleaning release" and > be done with it?
Sensible.
| |