lkml.org 
[lkml]   [2012]   [Mar]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [dm-devel] [PATCH] Fix I/O counts in vmstat
Hi Mikulas,

On 03/22/12 00:50, Mikulas Patocka wrote:
> On Wed, 21 Mar 2012, Jun'ichi Nomura wrote:
>>> The decision whether bio is counted or not is made by the code that
>>> submits the bio. This leads to some problems:
>>
>> How about convering dm targets to use generic_make_request?
>
> The problem would be raid1 resynchronization. There are no incoming bios
> when resynchronizing, but the administrator still needs to see the
> resynchronization workload in vmstat. The code path that submits bios for
> resynchronization is the same as the path that handles write requests.

Admins could see the workload with iostat or sar.
If pgpgout does not increase but iostat shows disk activity,
admins can tell resynchronization is going on.

> Also dm-over-loop would still result in double-counting, even if we use
> generic_make_request in dm.

It reflects the fact that writeback actually happens twice.

>> Since submit_bio counts vm events, it seems natural for
>> caller to decide which function to use.
>> Device driver does not know whether the requested I/O is
>> for vm-to-device or device-to-device.
>> We could still use iostat to measure throughput of individual
>> block devices.

--
Jun'ichi Nomura, NEC Corporation


\
 
 \ /
  Last update: 2012-03-22 03:09    [from the cache]
©2003-2011 Jasper Spaans