Messages in this thread | | | From | Bjorn Helgaas <> | Date | Wed, 21 Mar 2012 14:22:01 -0600 | Subject | Re: [PATCH] sky2: override for PCI legacy power management |
| |
On Wed, Mar 21, 2012 at 9:32 AM, Stephen Hemminger <shemminger@vyatta.com> wrote: > Some BIOS's don't setup power management correctly (what else is > new) and don't allow use of PCI Express power control. Add a special > exception module parameter to allow working around this issue. > Based on slightly different patch by Knut Petersen. > > Reported-by: Arkadiusz Miskiewicz <arekm@maven.pl> > Signed-off-by: Stephen Hemminger <shemminger@vyatta.com>
Is there a problem report URL you can include here?
It looks like this requires a user to figure out that he might be suffering from this problem, then use this module parameter to work around it. How would a user figure that out? Can we do it automatically to save him the trouble?
> --- > Patch against -net (ie. 3.3.0) > > --- a/drivers/net/ethernet/marvell/sky2.c 2012-01-10 10:56:56.855156017 -0800 > +++ b/drivers/net/ethernet/marvell/sky2.c 2012-03-21 08:25:52.400929532 -0700 > @@ -95,6 +95,10 @@ static int disable_msi = 0; > module_param(disable_msi, int, 0); > MODULE_PARM_DESC(disable_msi, "Disable Message Signaled Interrupt (MSI)"); > > +static int legacy_pme = 0; > +module_param(legacy_pme, int, 0); > +MODULE_PARM_DESC(legacy_pme, "Legacy power management"); > + > static DEFINE_PCI_DEVICE_TABLE(sky2_id_table) = { > { PCI_DEVICE(PCI_VENDOR_ID_SYSKONNECT, 0x9000) }, /* SK-9Sxx */ > { PCI_DEVICE(PCI_VENDOR_ID_SYSKONNECT, 0x9E00) }, /* SK-9Exx */ > @@ -867,6 +871,13 @@ static void sky2_wol_init(struct sky2_po > /* Disable PiG firmware */ > sky2_write16(hw, B0_CTST, Y2_HW_WOL_OFF); > > + /* Needed by some broken BIOSes, use PCI rather than PCI-e for WOL */ > + if (legacy_pme) { > + u32 reg1 = sky2_pci_read32(hw, PCI_DEV_REG1); > + reg1 |= PCI_Y2_PME_LEGACY; > + sky2_pci_write32(hw, PCI_DEV_REG1, reg1); > + } > + > /* block receiver */ > sky2_write8(hw, SK_REG(port, RX_GMF_CTRL_T), GMF_RST_SET); > sky2_read32(hw, B0_CTST); > -- > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > Please read the FAQ at http://www.tux.org/lkml/ -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |