lkml.org 
[lkml]   [2012]   [Mar]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 2/8] VFS: remove unused superblock helpers
    Date
    From: Artem Bityutskiy <artem.bityutskiy@linux.intel.com>

    Remove the 'sb_mark_dirty()', 'sb_mark_clean()' and 'sb_is_dirty()' helpers
    which are not used. I introduced them 2 years and the intention was to make
    all file-systems use them in order to be able to optimize 'sync_supers()'.
    However, Al Viro vetoed my patches at the end and asked me to push superblock
    management down to file-systems and get rid of the 's_dirt' flag completely,
    as well as kill 'sync_supers()' altogether. Thus, remove the helpers.

    Signed-off-by: Artem Bityutskiy <artem.bityutskiy@linux.intel.com>
    ---
    include/linux/fs.h | 13 -------------
    1 files changed, 0 insertions(+), 13 deletions(-)

    diff --git a/include/linux/fs.h b/include/linux/fs.h
    index 69cd5bb..68387e9 100644
    --- a/include/linux/fs.h
    +++ b/include/linux/fs.h
    @@ -1870,19 +1870,6 @@ extern struct dentry *mount_pseudo(struct file_system_type *, char *,
    const struct dentry_operations *dops,
    unsigned long);

    -static inline void sb_mark_dirty(struct super_block *sb)
    -{
    - sb->s_dirt = 1;
    -}
    -static inline void sb_mark_clean(struct super_block *sb)
    -{
    - sb->s_dirt = 0;
    -}
    -static inline int sb_is_dirty(struct super_block *sb)
    -{
    - return sb->s_dirt;
    -}
    -
    /* Alas, no aliases. Too much hassle with bringing module.h everywhere */
    #define fops_get(fops) \
    (((fops) && try_module_get((fops)->owner) ? (fops) : NULL))
    --
    1.7.7.6


    \
     
     \ /
      Last update: 2012-03-21 17:19    [W:0.023 / U:60.988 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site