[lkml]   [2012]   [Mar]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: Patch workqueue: create new slab cache instead of hacking
On Wed, 2012-03-21 at 09:12 -0500, Christoph Lameter wrote:
> How about this instead?
> Subject: workqueues: Use new kmem cache to get aligned memory for workqueues
> The workqueue logic currently improvises by doing a kmalloc allocation and
> then aligning the object. Create a slab cache for that purpose with the
> proper alignment instead.
> Cleans up the code and makes things much simpler. No need anymore to carry
> an additional pointer to the beginning of the kmalloc object.
> Signed-off-by: Christoph Lameter <>

Creating a dedicated cache for few objects ? Thats a lot of overhead, at
least for SLAB (no merges of caches)

By the way network stack also wants to align struct net_device (in
function alloc_netdev_mqs(), and uses a custom code.

In this case, as the size of net_device is not constant, we use standard

No idea why NETDEV_ALIGN is 32 ... Oh well, some old constant instead of

 \ /
  Last update: 2012-03-21 15:53    [W:0.107 / U:1.092 seconds]
©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site