Messages in this thread | | | Date | Tue, 20 Mar 2012 17:47:42 -0600 (MDT) | From | Paul Walmsley <> | Subject | Re: [PATCH 2/2] clk: Move init fields from clk to clk_hw |
| |
Hello Sascha
On Tue, 20 Mar 2012, Sascha Hauer wrote:
> [ C99 structure initializer elided ] > > This will make a 4000 line file out of a 500 line file. Now when for > some reason struct clk_divider changes we end with big patches. If the > clk core gets a new fancy CLK_ flag which we want to have then again > we end up with big patches. Then there's also the possibility that > someone finds out that .lock and .hw.flags are common to all dividers > and comes up with a #define DEFINE_CLK_DIVIDER again to share common > fields.
At least we can understand easily what is being changed. Readability, particularly by others not familiar with the clock data, is more important to me.
So like Saravana, I too prefer C99 structure initializers. At least there should be a choice.
Quick quiz: in this line below:
imx_clk_divider("foo_clk", "bar_clk", CCM_BASE + 0x20, 0x5, 0x3);
which field is the bitfield shift and which is the bitfield width? :-)
- Paul
| |