lkml.org 
[lkml]   [2012]   [Mar]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [RFC PATCH 2/6] slub: add kmalloc_align()
    On Tue, 20 Mar 2012, Christoph Lameter wrote:

    > > diff --git a/mm/slub.c b/mm/slub.c
    > > index 4907563..01cf99d 100644
    > > --- a/mm/slub.c
    > > +++ b/mm/slub.c
    > > @@ -3238,7 +3238,7 @@ static struct kmem_cache *__init create_kmalloc_cache(const char *name,
    > > * This function is called with IRQs disabled during early-boot on
    > > * single CPU so there's no need to take slub_lock here.
    > > */
    > > - if (!kmem_cache_open(s, name, size, ARCH_KMALLOC_MINALIGN,
    > > + if (!kmem_cache_open(s, name, size, ALIGN_OF_LAST_BIT(size),
    > > flags, NULL))
    > > goto panic;
    >
    > Why does the alignment of struct kmem_cache change? I'd rather have a
    > __alignof__(struct kmem_cache) here with alignment specified with the
    > struct definition.

    Ok this aligns the data not the cache . Ok I see what is going on here.
    So the kmalloc array now has a higher alignment. That means you can align
    up to that limit within the structure.



    \
     
     \ /
      Last update: 2012-03-20 15:23    [W:0.021 / U:63.516 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site