lkml.org 
[lkml]   [2012]   [Mar]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 09/10] cgroup: introduce struct cfent
On 03/17/2012 03:36 AM, Tejun Heo wrote:
> +static void cgroup_clear_directory(struct dentry *dir)
> +{
> + struct cgroup *cgrp = __d_cgrp(dir);
> +
> + while (!list_empty(&cgrp->files))
> + cgroup_rm_file(cgrp, NULL);
> + WARN_ON_ONCE(!list_empty(&dir->d_subdirs));
> }


I am hitting this warning here under pretty much normal conditions.
You forgot to account for trivial directories like "."

I'll send a patch ontop of what you have.



\
 
 \ /
  Last update: 2012-03-20 15:09    [W:0.236 / U:0.196 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site