[lkml]   [2012]   [Mar]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
    Patch in this message
    Subject[patch] edac i5000: fix pointer math in i5000_get_mc_regs()
    "pvt->ambase" is a u64 datatype.  The intent here is to fill the first
    half in the first call to pci_read_config_dword() and the other half in
    the second. Unfortunately the pointer math is wrong so we set the wrong

    Signed-off-by: Dan Carpenter <>
    I don't have the hardware to test this. Please review carefully.

    diff --git a/drivers/edac/i5000_edac.c b/drivers/edac/i5000_edac.c
    index 4dc3ac2..fcdc4ab 100644
    --- a/drivers/edac/i5000_edac.c
    +++ b/drivers/edac/i5000_edac.c
    @@ -1130,7 +1130,7 @@ static void i5000_get_mc_regs(struct mem_ctl_info *mci)
    pci_read_config_dword(pvt->system_address, AMBASE,
    (u32 *) & pvt->ambase);
    pci_read_config_dword(pvt->system_address, AMBASE + sizeof(u32),
    - ((u32 *) & pvt->ambase) + sizeof(u32));
    + (u32 *)((char *) &pvt->ambase + sizeof(u32)));

    maxdimmperch = pvt->maxdimmperch;
    maxch = pvt->maxch;

     \ /
      Last update: 2012-03-02 07:57    [W:0.028 / U:0.656 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site