Messages in this thread | | | Date | Fri, 2 Mar 2012 16:08:22 -0300 | From | Arnaldo Carvalho de Melo <> | Subject | Re: [PATCH] perf report: auto-detect branch stack sampling mode |
| |
Em Fri, Mar 02, 2012 at 06:47:38PM +0100, Stephane Eranian escreveu: > Arnaldo, > > What do you think about this patch?
I'm processing perf/core patches today, will get to this one and merge or let you know objections,
- Arnaldo
> > On Fri, Feb 24, 2012 at 4:51 PM, Stephane Eranian <eranian@google.com> wrote: > > On Fri, Feb 24, 2012 at 4:49 PM, David Ahern <dsahern@gmail.com> wrote: > >> On 2/24/12 8:40 AM, Stephane Eranian wrote: > >>> > >>> No, I don't. Read the code carefully. The for loop sets all known feature > >>> bits. > >>> Then, the ones not necessary or unused are turned off individually. > >> > >> > >> Ok, I see now. The __set_feat loop is earlier in builtin-record.c, not the > >> util code. > >> > > Yeah. Arnaldo simplified the original code in builtin-record.c to have the loop > > instead of individual set_feat(). > > > >> David
| |