Messages in this thread Patch in this message | | | Subject | [PATCH RFC/RFT] regulator: Fix mask parameter in da9052_reg_update calls | From | Axel Lin <> | Date | Fri, 02 Mar 2012 18:07:21 +0800 |
| |
If the mask parameter is 0, info->activate_bit bit won't be set by calling da9052_reg_update.
Signed-off-by: Axel Lin <axel.lin@gmail.com> --- Hi, I cannot find the datasheet, but current code looks does not make sense. Can someone confirm if this is a correct fix?
Regards, Axel
drivers/regulator/da9052-regulator.c | 8 ++++---- 1 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/regulator/da9052-regulator.c b/drivers/regulator/da9052-regulator.c index 3767364..ea4d8f5 100644 --- a/drivers/regulator/da9052-regulator.c +++ b/drivers/regulator/da9052-regulator.c @@ -260,8 +260,8 @@ static int da9052_set_ldo5_6_voltage(struct regulator_dev *rdev, * the LDO activate bit to implment the changes on the * LDO output. */ - return da9052_reg_update(regulator->da9052, DA9052_SUPPLY_REG, 0, - info->activate_bit); + return da9052_reg_update(regulator->da9052, DA9052_SUPPLY_REG, + info->activate_bit, info->activate_bit); } static int da9052_set_dcdc_voltage(struct regulator_dev *rdev, @@ -280,8 +280,8 @@ static int da9052_set_dcdc_voltage(struct regulator_dev *rdev, * the DCDC activate bit to implment the changes on the * DCDC output. */ - return da9052_reg_update(regulator->da9052, DA9052_SUPPLY_REG, 0, - info->activate_bit); + return da9052_reg_update(regulator->da9052, DA9052_SUPPLY_REG, + info->activate_bit, info->activate_bit); } static int da9052_get_regulator_voltage_sel(struct regulator_dev *rdev) -- 1.7.5.4
| |