lkml.org 
[lkml]   [2012]   [Mar]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: Resend [PATCH] netfilter: Fix copy_to_user too small size parametre.
On Fri, Mar 02, 2012 at 09:05:10AM -0000, David Laight wrote:
> > - if (copy_to_user(hlp, m->u.match->name,
> > EBT_FUNCTION_MAXNAMELEN))
> > + char name[EBT_FUNCTION_MAXNAMELEN] = {};
> > +
> > + strncpy(name, m->u.match->name, sizeof(name));
> > + if (copy_to_user(hlp, name, EBT_FUNCTION_MAXNAMELEN))
> > return -EFAULT;
>
> strncpy() is very rarely the function you are looking for.
> In this case it MIGHT be right (since you do a fixed size
> copy_to_user).
> OTOH there is no need to also initialise name[].

We have to make sure that array is filled with zeros for the gap
between byte 29 and byte 32 due to backward compatibility issues.

I'll mangle the patch to add some comment close to strncpy and to
explain the way we're doing this.

> And it isn't entirely clear whether the application
> is allowed to be given a non-terminated string.

Match names are 29 bytes long, while ebtables expects 32 bytes. So
we're copying less bytes.

We can add the final \0 if you feel more confortable, but that string
is going to be null-terminated the way the code look now.


\
 
 \ /
  Last update: 2012-03-02 11:03    [from the cache]
©2003-2014 Jasper Spaans. hosted at Digital Ocean