Messages in this thread Patch in this message | | | Date | Fri, 2 Mar 2012 01:51:26 -0800 | From | tip-bot for David Ahern <> | Subject | [tip:perf/urgent] perf tools: Ensure comm string is properly terminated |
| |
Commit-ID: cfbd70c17c4535e64be92ea442a2a45078a18184 Gitweb: http://git.kernel.org/tip/cfbd70c17c4535e64be92ea442a2a45078a18184 Author: David Ahern <dsahern@gmail.com> AuthorDate: Fri, 24 Feb 2012 12:31:38 -0700 Committer: Arnaldo Carvalho de Melo <acme@redhat.com> CommitDate: Wed, 29 Feb 2012 18:29:45 -0300
perf tools: Ensure comm string is properly terminated
If threads in a multi-threaded process have names shorter than the main thread the comm for the named threads is not properly terminated.
E.g., for the process 'namedthreads' where each thread is named noploop%d where %d is the thread number:
Before: perf script -f comm,tid,ip,sym,dso noploop:4ads 21616 400a49 noploop (/tmp/namedthreads) The 'ads' in the thread comm bleeds over from the process name.
After: perf script -f comm,tid,ip,sym,dso noploop:4 21616 400a49 noploop (/tmp/namedthreads)
Cc: Frederic Weisbecker <fweisbec@gmail.com> Cc: Ingo Molnar <mingo@elte.hu> Cc: Paul Mackerras <paulus@samba.org> Cc: Peter Zijlstra <peterz@infradead.org> Cc: Thomas Gleixner <tglx@linutronix.de> Link: http://lkml.kernel.org/r/1330111898-68071-1-git-send-email-dsahern@gmail.com Signed-off-by: David Ahern <dsahern@gmail.com> Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com> --- tools/perf/util/event.c | 1 + 1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/tools/perf/util/event.c b/tools/perf/util/event.c index 2044324..2a6f33c 100644 --- a/tools/perf/util/event.c +++ b/tools/perf/util/event.c @@ -74,6 +74,7 @@ static pid_t perf_event__get_comm_tgid(pid_t pid, char *comm, size_t len) if (size >= len) size = len - 1; memcpy(comm, name, size); + comm[size] = '\0'; } else if (memcmp(bf, "Tgid:", 5) == 0) { char *tgids = bf + 5;
| |