lkml.org 
[lkml]   [2012]   [Mar]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 2/3] i2c-s3c2410: Rework device type handling
On Thu, Mar 15, 2012 at 05:54:33PM +0100, Karol Lewandowski wrote:

> If you consider code to be inherently less readable because of this
> approach I'll rework it. If it's not a such big deal for you I would
> prefer to keep it as is.

The thing that was causing me to think the code was funny was mainly the
fact that we're now combining both quirk based selection and chip type
based selection into the same bitmask. If the chip types were quirks
it'd probably not have looked odd, and that might just be a case of
renaming them - I can't remember what they do.
[unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2012-03-19 20:57    [W:0.060 / U:3.620 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site