Messages in this thread | | | From | "Turquette, Mike" <> | Date | Mon, 19 Mar 2012 12:33:05 -0700 | Subject | Re: [PATCH v7 2/3] clk: introduce the common clock framework |
| |
On Mon, Mar 19, 2012 at 12:13 PM, Saravana Kannan <skannan@codeaurora.org> wrote: > I saw some responses from you over the weekend but not to mine. So, I > assumed you were busy with other stuff and I started working on a patch on > top of v7.
I only answer trivial emails on the weekend ;-)
> I will send that out if I get around to finishing it before you > do. Hope that's alright with you.
I'm happy to for you to take a crack at it. I don't know what your implementation looks like, but here are a couple concerns I have:
1) if you're copying the data from the initializer over to the struct clk then make sure you handle the __init data aspects of it properly
2) are the members of struct clk_hw visible to the rest of the world? Are they modifiable (i.e., not const)? This is undesirable.
Thanks, Mike
| |