Messages in this thread | | | Date | Sun, 18 Mar 2012 12:09:53 +0100 | From | Lars-Peter Clausen <> | Subject | Re: [PATCH v2 2/2] regulator: Convert pcf50633 to get_voltage_sel |
| |
On 03/17/2012 01:08 AM, Axel Lin wrote: > Convert pcf50633 to get_voltage_sel and then we can remove > pcf50633_regulator_voltage_value function and move its implementation > to pcf50633_regulator_list_voltage. > > Signed-off-by: Axel Lin <axel.lin@gmail.com>
Acked-by: Lars-Peter Clausen <lars@metafoo.de>
One minor comment inline though.
> --- > drivers/regulator/pcf50633-regulator.c | 65 ++++++++++++++----------------- > 1 files changed, 29 insertions(+), 36 deletions(-) > > diff --git a/drivers/regulator/pcf50633-regulator.c b/drivers/regulator/pcf50633-regulator.c > index 9ef7dff..b02cbb9 100644 > --- a/drivers/regulator/pcf50633-regulator.c > +++ b/drivers/regulator/pcf50633-regulator.c > @@ -151,23 +151,43 @@ static int pcf50633_regulator_set_voltage(struct regulator_dev *rdev, > return pcf50633_reg_write(pcf, regnr, volt_bits); > } > > -static int pcf50633_regulator_voltage_value(enum pcf50633_regulator_id id, > - u8 bits) > +static int pcf50633_regulator_get_voltage_sel(struct regulator_dev *rdev) > { > + struct pcf50633 *pcf; > + int regulator_id; > + u8 volt_bits, regnr; > + > + pcf = rdev_get_drvdata(rdev); > + > + regulator_id = rdev_get_id(rdev); > + if (regulator_id >= PCF50633_NUM_REGULATORS) > + return -EINVAL; > + > + regnr = pcf50633_regulator_registers[regulator_id]; > + > + volt_bits = pcf50633_reg_read(pcf, regnr); > + > + return volt_bits;
Might as well just do "return pcf50633_reg_read(pcf, regnr);"
| |