lkml.org 
[lkml]   [2012]   [Mar]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH] firmware loader: don't cancel _nowait requests when helper is not yet available
Date
On Saturday, March 17, 2012, Linus Torvalds wrote:
> On Fri, Mar 16, 2012 at 7:47 PM, Stephen Boyd <sboyd@codeaurora.org> wrote:
> > - if (WARN_ON(usermodehelper_is_disabled())) {
> > + if (is_sleep_task()) {
> > dev_err(device, "firmware: %s will not be loaded\n", name);
>
> Stop these idiotic games already!
>
> It's very simple: you cannot load firmware while the system is not
> readt. Your moronic "let's change the test to something else" is
> entirely and utterly misguided and totally misses the point.
>
> It's not about sleeping, and it's not about anything even *remotely*
> about that. Stop the idiocy already.
>
> How hard is it to understand? How many times do people have to tell you?
>
> That warning is very much valid during bootup, and that warning has
> been *seen* during bootup. For example, try to compile in most
> wireless drivers as non-modular, and that warning *has* to trigger.
>
> Rafael, please consider everything along these *IDIOTIC* lines
> completely NAK'ed.

I will.

Thanks,
Rafael


\
 
 \ /
  Last update: 2012-03-17 21:05    [from the cache]
©2003-2011 Jasper Spaans